Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F# #127

Merged
merged 9 commits into from
May 2, 2021
Merged

Add F# #127

merged 9 commits into from
May 2, 2021

Conversation

purkhusid
Copy link
Contributor

What?

This PR adds the following:

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lang-csharp C# rules specific labels Apr 19, 2021
@purkhusid
Copy link
Contributor Author

This is ready for review

@aaliddell
Copy link
Member

Wow, awesome! I'll take a look at this on the weekend or sooner if I get a chance.

I still need to get back to you on platforms/toolchains topic on rules_dotnet, but I need to make a demo repo to check it

@purkhusid
Copy link
Contributor Author

awesome! I'll take a look at this on the weekend or sooner if I get a chance.

I still need to get back to you on platforms/toolchains topic on rules_dotnet, but I need to make a demo repo to check it

Sounds great! I would love to find a way to configure rules_dotnet without platform flags that also works with target_compatible_with

@aaliddell
Copy link
Member

Merging into dev in advance of 3.2.0. Thanks!

@aaliddell aaliddell changed the base branch from master to dev May 2, 2021 17:14
@aaliddell aaliddell merged commit e118d85 into rules-proto-grpc:dev May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lang-csharp C# rules specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants