-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel 1.0 support #36
Conversation
…hen using import_prefix
repositories.bzl
Outdated
"ref": "6415663945d3248207da955aafa1fa2af1a0f2ed", | ||
"sha256": "d1e28237d1f4c2255c504246b4f3fd36f74d590f2974491b4399a84c58b495ed", | ||
"ref": "0.28.0", | ||
"sha256": "d1e28237d1a4c2255c504246b4f3fd36f74d590f2974491b4399a84c58b495ed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel reports 5ec71602e9b458b01717fab1d37492154c1c12ea83f881c745dbd88e9b2098d8
for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, fixed, thanks
For info, to get the C# generated code to be compatible with the nuget packages, I had to upgrade the grpc and protobuf packages to their latest versions: |
All languages except Scala are now working and at this point I'm considering bumping Scala support off the 1.0.0 target and disabling its tests in CI, as it's taking a massively disproportionate amount of my time to troubleshoot and subsequently delaying this merge. Scala support can be fixed in 1.1.0 if that's the decision made.
I can't ever get the C# rules to work, let alone update the packages. Could you provide the changes as a PR based on this branch, so I can see if any tests work? Or see if #34 is the same? |
Unfortunately I can’t manage to build any of the examples here, and I’m pretty much lost in the whole .net frameworks, rules and nuget bazel files generations, so I’m not yet able to provide any proper PR. It’s the same kind of changes as #34. I’m trying to better understand the C# rules and nuget2bazel stuff, hopefully I’ll be able to contribute here. |
rules_python is not parsing METADATA, meaning these requirements get missed
TODO:
Fix scalaCloses #22, #14, #8, #10, #4, #23, #30