WIP: add secret storage. #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Mar 11, 2022
|
|
||
| pub mod default_key; | ||
| pub mod key; | ||
| pub mod some_secret; |
There was a problem hiding this comment.
I can't find this in the v1.2 spec which includes secret storage. It also seems like it was just a placeholder originally (based on the name). This should probably be removed.
|
Actually I'll close this so the current state (what was done last year's GSoC) is archived in a way. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need #686 to be resolved and works towards: #478.
This PR also needs more work on top of solving the event name issue.