Separate utils #30
Open
Separate utils #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 16, 2020 14:23
|
@rumkin one 1.5, custom events, and lodash dependency are merged, should I resolve/refactor this one? I think it's a good idea to separate out as much of the library as we can so we can unit test, etc. |
|
@rumkin Cool I should have time this weekend to work on it. |
|
@rumkin Is it cool to continue with this PR or should we shelve it? I am totally game for fixing the conflicts. |
|
You can fix conflicts or just create new PR, if it would be too messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved the utility functions out and annotated them for sanity. They can now also be unit tested more easily.