-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gov xmod to gaia-rs #317
Conversation
Currently if we try to overwrite a saved tree version we ignore the error. We shuld never be trying to overwrite a saved version and if we do then either the db is corrupted or we have a bug.
} | ||
|
||
#[derive(Debug, Clone, PartialEq, Eq, strum::EnumIter, Hash, PartialOrd, Ord)] | ||
pub enum GaiaXmodules { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to point that this enum helps to update info about modules version. After each upgrade there should be list with module and version. strum::EnumIter
helps to init things as we do with store keys.
@@ -132,6 +138,10 @@ impl< | |||
} | |||
self.gov_params_keeper.set(ctx, params); | |||
|
|||
self.auth_keeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a part of gaia? You added a new keeper only for simple creation of account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I thin it would be best to stick to how Cosmos do it i.e. inside the module.
It possible that where modules are initialized changes the end state of the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
No description provided.