Skip to content

Commit

Permalink
Remove proc.wait() on tunnel close to fix hanging termination
Browse files Browse the repository at this point in the history
  • Loading branch information
dongreenberg committed Jul 2, 2024
1 parent f018c5c commit 7846e51
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion runhouse/resources/hardware/sky_ssh_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ def terminate(self):

# Process keeping tunnel alive can only be killed with EOF
self.tunnel_proc.stdin.close()
self.tunnel_proc.wait()

# Remove port forwarding
port_fwd_cmd = " ".join(
Expand Down

0 comments on commit 7846e51

Please sign in to comment.