Skip to content

Commit

Permalink
update sky runner
Browse files Browse the repository at this point in the history
  • Loading branch information
carolineechen committed Aug 20, 2024
1 parent fd57b7a commit a1af88c
Show file tree
Hide file tree
Showing 6 changed files with 366 additions and 187 deletions.
6 changes: 2 additions & 4 deletions runhouse/resources/hardware/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -1197,10 +1197,9 @@ def rsync(
)

runner = SkySSHRunner(
node,
(node, self.ssh_port),
**ssh_credentials,
ssh_control_name=ssh_control_name,
port=self.ssh_port,
docker_user=self.docker_user,
)
if not pwd:
Expand Down Expand Up @@ -1416,10 +1415,9 @@ def _run_commands_with_ssh(
)

runner = SkySSHRunner(
host,
(host, self.ssh_port),
**ssh_credentials,
ssh_control_name=ssh_control_name,
port=self.ssh_port,
docker_user=self.docker_user,
)

Expand Down
3 changes: 1 addition & 2 deletions runhouse/resources/hardware/on_demand_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,8 @@ def ssh(self, node: str = None):
raise FileNotFoundError(f"Expected default sky key in path: {sky_key}")

runner = SkySSHRunner(
ip=node or self.address,
(node or self.address, self.ssh_port),
ssh_user=ssh_user,
port=self.ssh_port,
ssh_private_key=str(sky_key),
docker_user=self.docker_user,
)
Expand Down
3 changes: 1 addition & 2 deletions runhouse/resources/hardware/sagemaker/sagemaker_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,7 @@ def _run_commands_with_ssh(
from runhouse.resources.hardware.sky_ssh_runner import SkySSHRunner

runner = SkySSHRunner(
self.name,
port=self.ssh_port,
(self.name, self.ssh_port),
ssh_user=self.DEFAULT_USER,
ssh_private_key=self._abs_ssh_key_path,
ssh_control_name=f"{self.name}:{self.ssh_port}",
Expand Down
Loading

0 comments on commit a1af88c

Please sign in to comment.