Runhouse ssh into local clusters #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
jlewitt1
reviewed
Jul 16, 2024
jlewitt1
reviewed
Jul 16, 2024
| address=resource_handle.head_ip, | ||
| ssh_user=resource_handle.ssh_user or "ubuntu", | ||
| ssh_port=resource_handle.stable_ssh_ports[0] or DEFAULT_SSH_PORT, | ||
| ssh_private_key=OnDemandCluster.DEFAULT_KEYFILE, |
There was a problem hiding this comment.
does this support relative key paths?
There was a problem hiding this comment.
both relative and absolute seem to work
jlewitt1
reviewed
Jul 16, 2024
| if not c.is_shared: | ||
| if up: | ||
| try: | ||
| c.up_if_not() |
There was a problem hiding this comment.
Suggested change
| c.up_if_not() | |
| c = c.up_if_not() |
might be an edge case, but if the cluster isn't actually up and we do bring it back, we don't want to be storing stale IPs, which returning the updated cluster object prevents
There was a problem hiding this comment.
it looks like up_if_not and up does directly update the fields of the original cluster object, even if we don't reassign it with the new returned object
jlewitt1
reviewed
Jul 16, 2024
jlewitt1
reviewed
Jul 16, 2024
carolineechen
force-pushed
the
cc/ssh-local
branch
from
ae7c983
to
91072f7
Compare
carolineechen
force-pushed
the
cc/ssh-local
branch
from
91072f7
to
b1b5fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.