Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix folder construction in package #1083

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix folder construction in package #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion runhouse/resources/packages/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,11 @@ def from_string(specifier: str, dryrun=False):
# Check if this is a package that was installed from local
local_install_path = get_local_install_path(target)
if local_install_path and Path(local_install_path).exists():
target = Folder(path=local_install_path, dryrun=True)
from runhouse.resources.folders import Folder

target = Folder(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

path=local_install_path, system=Folder.DEFAULT_FS, dryrun=True
)

# "Local" install method is a special case where we just copy a local folder and add to path
if install_method == "local":
Expand Down
Loading