Deprecate some old unused function methods #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dongreenberg and the rest of your teammates on |
dongreenberg
force-pushed
the
deprecate_function_send_secrets
branch
from
c402580
to
1cfa25b
Compare
dongreenberg
force-pushed
the
deprecate_old_fn_methods
branch
from
268f621
to
7245530
Compare
jlewitt1
approved these changes
Aug 24, 2024
dongreenberg
force-pushed
the
deprecate_function_send_secrets
branch
from
1cfa25b
to
ca6f982
Compare
dongreenberg
force-pushed
the
deprecate_old_fn_methods
branch
from
7245530
to
800e275
Compare
jlewitt1
force-pushed
the
deprecate_function_send_secrets
branch
from
ca6f982
to
3ed54aa
Compare
jlewitt1
force-pushed
the
deprecate_old_fn_methods
branch
from
800e275
to
e0cc1ef
Compare
# Conflicts: # runhouse/resources/functions/function.py # runhouse/resources/functions/function_factory.py # tests/test_resources/test_modules/test_functions/test_function.py
BelSasha
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: jlewitt1 <josh@run.house>
BelSasha
pushed a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: jlewitt1 <josh@run.house>
BelSasha
pushed a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: jlewitt1 <josh@run.house>
BelSasha
pushed a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: jlewitt1 <josh@run.house>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.