Add docker dev prod workflow guide #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
dongreenberg
reviewed
Aug 1, 2024
docs/guides/docker-dev.rst
Outdated
Comment on lines
24
to
26
| (0.16.0), and Accelerate (0.28.0). We will use both the container | ||
| version of these packages, as well as local editable versions, of the | ||
| diffusers and transformers packages to showcase both production ready |
There was a problem hiding this comment.
Delete "of the diffusers and transformers packages"
dongreenberg
reviewed
Aug 1, 2024
docs/guides/docker-dev.rst
Outdated
| cluster.up_if_not() | ||
|
|
||
| The function we’ll be using in our demo is ``is_transformers_available`` | ||
| from ``diffusers.utils``. We’ll first show what using this function like |
There was a problem hiding this comment.
Suggested change
| from ``diffusers.utils``. We’ll first show what using this function like | |
| from ``diffusers.utils``. We’ll first show what using this function |
dongreenberg
reviewed
Aug 1, 2024
docs/guides/docker-dev.rst
Outdated
Comment on lines
74
to
75
| show the case if we had a local version of the repositories, that we | ||
| modified locally, and wanted to test out the change on the cluster. |
There was a problem hiding this comment.
Suggested change
| show the case if we had a local version of the repositories, that we | |
| modified locally, and wanted to test out the change on the cluster. | |
| show the case if we had local versions of the repositories that we'd | |
| modified and wanted to test out our changes on the cluster. |
dongreenberg
reviewed
Aug 1, 2024
docs/guides/docker-dev.rst
Outdated
Comment on lines
84
to
87
| The core of the production workflow is that the Docker image consists of | ||
| the exact packages and versions that you want. Regardless of whether or | ||
| not one has local edits, these edits should **not** be used in the | ||
| production workflow. |
There was a problem hiding this comment.
Suggested change
| The core of the production workflow is that the Docker image consists of | |
| the exact packages and versions that you want. Regardless of whether or | |
| not one has local edits, these edits should **not** be used in the | |
| production workflow. | |
| The core of the production workflow is that the Docker image already contains | |
| the exact packages and versions we want, probably published into the registry in CI/CD. | |
| We don't want to perform any installs or code changes within the image throughout | |
| execution so we preserve exact reprodicubility. |
dongreenberg
reviewed
Aug 1, 2024
docs/guides/docker-dev.rst
Outdated
Comment on lines
89
to
95
| **NOTE**: By default, Ray and Runhouse are installed on the ondemand | ||
| cluster during setup time. This may be the most updated version of | ||
| Runhouse, or the version you have cloned and installed locally. To make | ||
| sure that your version is pinned for production use cases, please make | ||
| sure that you have Runhouse and Ray included on the Docker container; | ||
| the setup will skip the installations if it detects that they are | ||
| already installed on the cluster. |
There was a problem hiding this comment.
Suggested change
| **NOTE**: By default, Ray and Runhouse are installed on the ondemand | |
| cluster during setup time. This may be the most updated version of | |
| Runhouse, or the version you have cloned and installed locally. To make | |
| sure that your version is pinned for production use cases, please make | |
| sure that you have Runhouse and Ray included on the Docker container; | |
| the setup will skip the installations if it detects that they are | |
| already installed on the cluster. | |
| **NOTE**: By default, Ray and Runhouse are installed on the ondemand | |
| cluster during setup time (generally attempting to match the versions you | |
| have locally), unless we detect that they're already present. To make | |
| sure that no installs occur in production, please make | |
| sure that you have Runhouse and Ray installed in your docker image. |
dongreenberg
approved these changes
Aug 1, 2024
carolineechen
force-pushed
the
cc/docker-guide
branch
5 times, most recently
from
715ddc6
to
57c6fc9
Compare
carolineechen
added a commit
that referenced
this pull request
Aug 2, 2024
carolineechen
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.