Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folder as resource fixes #1147

Merged
merged 1 commit into from
Aug 15, 2024
Merged

folder as resource fixes #1147

merged 1 commit into from
Aug 15, 2024

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Aug 14, 2024 •
edited
Loading

  • serializing folder contents where appropriate before sending them over the wire with http_client.put()
  • fixing Folder ls call when calling via HTTP
  • revert Folder to inherit as a resource for now
  • revert docker folder fixture to no longer be associated with test org
  • Get CI fully passing

@jlewitt1 Graphite App
Copy link
Collaborator Author

jlewitt1 commented Aug 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jlewitt1 and the rest of your teammates on Graphite Graphite

@jlewitt1 jlewitt1 mentioned this pull request Aug 14, 2024
Closed
@jlewitt1 jlewitt1 force-pushed the folder-as-resource branch 2 times, most recently from d31679d to 2d24c8a Compare August 14, 2024 17:32
@jlewitt1 jlewitt1 changed the title revert folder back to resource for now folder as resource fixes Aug 14, 2024
@jlewitt1 jlewitt1 force-pushed the folder-as-resource branch 5 times, most recently from 2305f8f to 748e8f4 Compare August 14, 2024 22:06
@jlewitt1 jlewitt1 marked this pull request as ready for review August 14, 2024 22:22
@jlewitt1 jlewitt1 requested a review from rohinb2 August 14, 2024 22:48
rohinb2
rohinb2 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@rohinb2 rohinb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't read in depth stamping to unblock ci fixed

@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 15, 2024

Money Sadie GIF (Added via Giphy)

@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 15, 2024

Graphite Automations

"rohin" took an action on this PR • (08/15/24)

1 gif was posted to this PR based on Rohin Bhasin's automation.

@jlewitt1 jlewitt1 merged commit bc54e31 into main Aug 15, 2024
13 checks passed
@jlewitt1 jlewitt1 deleted the folder-as-resource branch August 15, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohinb2 rohinb2 rohinb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlewitt1 @rohinb2