Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sky resource properties to cluster launched properties #1246

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

carolineechen
Copy link
Collaborator

to add to launched_properties, but not directly from sky - memory, os

Copy link

sentry-io bot commented Sep 9, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
_populate_connection_from_status_dict ValueError: Sky's cluster status does not have the necessary information to connect to the cluster. Please ch... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

@carolineechen carolineechen merged commit 963a2d3 into main Sep 11, 2024
12 checks passed
@carolineechen carolineechen deleted the cc/more-launched-properties branch September 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants