[WIP] fix cluster list release tests for k8 #1407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelSasha
force-pushed
the
sb/cli-release-tests-fix
branch
from
dab752b
to
b15b484
Compare
BelSasha
commented
Nov 13, 2024
| **kwargs, | ||
| ) | ||
| try: | ||
| c = Cluster.from_name(name=name) |
There was a problem hiding this comment.
decided to use Cluster.from_name(name=name) instead of OnDemandCluster.from_name for constancy in the cluster_factory.py.
Need to decide wether to leave it as Cluster.from_name(name=name) or change it to OnDemandCluster.from_name(name=name) everywhere. In my opinion the latter makes more sense because as Josh mentioned we use OnDemandCluster constructor if we catch a ValueError. Is there a reason for using Cluster.from_name?
BelSasha
force-pushed
the
sb/cli-release-tests-fix
branch
2 times, most recently
from
deb10b3
to
043f692
Compare
BelSasha
changed the title
BelSasha
force-pushed
the
sb/cli-release-tests-fix
branch
from
043f692
to
49b068b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it was intentional, but in the cluster factory, k8 clusters were not created by name. This caused some cluster list tests to fail when running them with --level local (specifically for k8 on demand clusters).
Changes I made:
After the change I introduced in this PR:
cluster listtests passed for me. Have not seen any consistency issues. (Ran those tests few times).pytest -v --level release -k "clustertest"locally, usedden_tester)@carolineechen @jlewitt1