Replace cluster internal_external_ips attribute with internal_ips

[carolineechen]

replace self.internal_external_ips with just self.internal_ips (self.ips already stores external ips). leave ability to load internal_external_ips from kwargs for backwards compatibility for now.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function	Unhandled Issue
_sync_default_env_to_cluster	AttributeError: 'OnDemandCluster' object has no attribute 'secrets' runhouse.resources.hardware.cluster in _sync_def... Event Count: 1
__init__	ValueError: Could not locate secret ssh-sky-key _... Event Count: 1

📄 File: runhouse/resources/hardware/on_demand_cluster.py (Click to Expand)

Function	Unhandled Issue
__init__	AttributeError: module 'sky' has no attribute 'global_user_state' __m... Event Count: 2

---

_{Did you find this useful? React with a 👍 or 👎}

[carolineechen]

• Rename launched_properties as compute_properties #1430
• Move ips into launched properties attribute #1429
• Force cluster ips to be a list #1426
• Replace cluster internal_external_ips attribute with internal_ips #1417 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[jlewitt1]

maybe we should rebase this onto the PRs moving IPs into launched properties and making into a list?

[carolineechen]

@jlewitt1 those PRs are rebased onto this one so it should be the same in the end either way - this + the list one should be good to go, and still need to fix a few spots I missed for the last 2 PRs in the stack