Update cluster list tests #1418
Open
+104
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
carolineechen
force-pushed
the
cc/cluster-list-tests
branch
from
8b8c8a0
to
ec26ed2
Compare
BelSasha
reviewed
Nov 18, 2024
| assert len(running_clusters) > 0 | ||
| assert len(running_clusters) == len( | ||
| all_clusters | ||
| all_clusters = Cluster.list(show_all=True).get("den_clusters", {}) |
There was a problem hiding this comment.
I think that this we should not remove test_cluster_list_pythonic (maybe just re-name it if necessary), because it tests the default behaviour of Cluster.list().
Seems to me we are going to show by default only part of the running clusters by default (based on @carolineechen comments on Josh's PR), so IMO we need to have two separate tests:
- Default behavior of Cluster.list()
- Tests the behaviour of Cluster.list(show_all=true)
wdyt?
| @@ -1035,7 +1026,7 @@ def test_cluster_list_pythonic(self, cluster): | |||
|
|
|||
| @pytest.mark.level("local") | |||
| @pytest.mark.clustertest | |||
| def test_cluster_list_all_pythonic(self, cluster): | |||
There was a problem hiding this comment.
Similar to the note above, not sure that we need to delete this test
BelSasha
force-pushed
the
cc/cluster-list-tests
branch
from
18ed652
to
ed562d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.