Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssh secrets for den launcher with org #1432

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mkandler
Copy link
Contributor

@mkandler mkandler commented Nov 15, 2024

When launching a cluster for an organization via Den, there were two issues:

  • Cluster is originally saved with default creds that we always overwrite
  • Creds are switched into the org folder automatically (e.g. mkandler/ssh-sky-key -> runhouse/ssh-sky-key) when saving

So.

  • Added a field to skip the creds setup for Den on-demand clusters
  • Automatic folder switching only happens if the Secret doesn't have an _rns_folder

Wondering if some of that folder logic can be removed entirely? Especially with some of the upcoming image/env changes.

Copy link

sentry-io bot commented Nov 15, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
__init__ ValueError: Could not locate secret ssh-sky-key _...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor Author

mkandler commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

mkandler commented Nov 18, 2024

Merge activity

  • Nov 18, 10:57 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 18, 11:01 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 18, 11:02 AM EST: A user merged this pull request with Graphite.

@mkandler mkandler changed the base branch from 11-15-set_sky_secret_on_den_clusters to graphite-base/1432 November 18, 2024 15:58
@mkandler mkandler changed the base branch from graphite-base/1432 to main November 18, 2024 15:59
@mkandler mkandler force-pushed the 11-15-fix_ssh_secrets_for_den_launcher_with_org branch from 0a79a47 to 6053207 Compare November 18, 2024 16:00
@mkandler mkandler merged commit 69558f2 into main Nov 18, 2024
13 checks passed
@mkandler mkandler deleted the 11-15-fix_ssh_secrets_for_den_launcher_with_org branch November 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants