Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SageMaker Cluster updates #166

Merged
merged 8 commits into from
Nov 30, 2023
Merged

SageMaker Cluster updates #166

merged 8 commits into from
Nov 30, 2023

Conversation

jlewitt1
Copy link
Collaborator

Various updates based on latest main branch:

  • Managing the SSH connection with the cluster
  • Tests

@jlewitt1 Graphite App
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jlewitt1 jlewitt1 force-pushed the sagemaker-updates branch 8 times, most recently from ba5915e to 1dd2a41 Compare November 28, 2023 09:27
@jlewitt1 jlewitt1 marked this pull request as ready for review November 28, 2023 15:11
@jlewitt1 jlewitt1 force-pushed the sagemaker-updates branch 2 times, most recently from bb32ab2 to b621187 Compare November 29, 2023 12:38
@dongreenberg @jlewitt1
Bugfixes. We haven't been adding ssh_port and client_port to config_f…
b36d1f9 
…or_rns, but we do here to ensure tunnel is recreated properly for local docker clusters.
@dongreenberg dongreenberg merged commit aab3a3c into main Nov 30, 2023
5 checks passed
@dongreenberg dongreenberg deleted the sagemaker-updates branch November 30, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongreenberg dongreenberg dongreenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlewitt1 @dongreenberg