Fix use of open_cluster_tunnels cache to account for dead connections. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
rohinb2
force-pushed
the
rohin/fix-ssh-tunnel-caching
branch
3 times, most recently
from
82e9c16
to
0a9627b
Compare
rohinb2
commented
Dec 5, 2023
| @@ -555,7 +553,7 @@ def ssh(self, interactive: bool = True): | |||
| >>> rh.sagemaker_cluster(name="sagemaker-cluster").ssh() | |||
| """ | |||
|
|
|||
| if self.instance_id not in open_cluster_tunnels: | |||
| if self.instance_id not in ssh_tunnel_cache: | |||
There was a problem hiding this comment.
uhh @jlewitt1, is the instance_id in the form of (address, port)?
rohinb2
force-pushed
the
rohin/fix-ssh-tunnel-caching
branch
from
0a9627b
to
7975f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run local tests, but individually (when running together we still get some cluster issues):
Server tests:
pytest -v --level local -k "not TestFunction and not TestEnv and not TestCluster and not TestResourceCluster & Resource:
pytest -v --level local -k "TestCluster or TestResource"Function:
pytest -v --level local -k "TestFunction"