Update deprecations and corresponding fn signatures #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carolineechen
commented
Dec 14, 2023
carolineechen
commented
- deprecate access_type, with warning, instead of BC-breaking (remove in future release)
- update function signatures w/ deprecated arguments to hide those arguments
- correct funciton_factory file name to function_factory
carolineechen
force-pushed
the
cc/deprecations
branch
from
84da9ae
to
e2e4d96
Compare
jlewitt1
reviewed
Dec 14, 2023
jlewitt1
approved these changes
Dec 14, 2023
carolineechen
force-pushed
the
cc/deprecations
branch
2 times, most recently
from
9e003b6
to
725d4d8
Compare
jlewitt1
reviewed
Dec 14, 2023
| @@ -377,6 +380,13 @@ def share( | |||
| f"For example: `{self.name}.to(system='s3')`" | |||
| ) | |||
|
|
|||
| if access_type: | |||
| logger.warning( | |||
There was a problem hiding this comment.
use warnings instead of logger here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.