Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambdas / Factory API smoothing #244

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Lambdas / Factory API smoothing #244

merged 7 commits into from
Dec 20, 2023

Conversation

BelSasha
Copy link
Contributor

Main changes:

  1. Lambda function factory smoothing (removed args_names, paths_to_code, handler_funciton_name)
  2. Enabling creating lambda function with a path to code using LambdaFunction.from_handler_file method.
  3. Remove tests that became redundant after the refactor.

Copy link
Contributor

@dongreenberg dongreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work!! Just had one note about the delete and delete_from_den methods - we can get rid of delete_from_den because delete_configs is already inherited from resource, and can we use teardown as the method to delete the lambda itself to be consistent with cluster?

@BelSasha BelSasha merged commit ab3cb07 into main Dec 20, 2023
4 checks passed
@jlewitt1 jlewitt1 deleted the sb/lambda-from-handler branch December 26, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants