Change Module's endpoint from propery to function #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
dongreenberg
force-pushed
the
module_endpoint_not_property
branch
from
69bf5d2
to
e1fd06c
Compare
This allows us to set external=True or False, in case we want a locally-callable endpoint. Previously if the endpoint was only locally callable, we would only return None. This is now also consistent with Cluster's endpoint().
dongreenberg
force-pushed
the
module_endpoint_not_property
branch
from
e1fd06c
to
2ccc007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to set external=True or False, in case we want a locally-callable
endpoint. Previously if the endpoint was only locally callable, we would only return
None. This is now also consistent with Cluster's endpoint().