Rename cluster default env name when empty #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
carolineechen
force-pushed
the
cc/rename-default-env
branch
7 times, most recently
from
c2df812
to
02c50a9
Compare
carolineechen
force-pushed
the
cc/unnamed-env-docs
branch
from
f1db3d8
to
d03c2f3
Compare
carolineechen
force-pushed
the
cc/rename-default-env
branch
from
02c50a9
to
a4975f0
Compare
rohinb2
approved these changes
May 6, 2024
|
|
Graphite Automations"rohin" took an action on this PR • (05/06/24)1 gif was posted to this PR based on Rohin Bhasin's automation. |
carolineechen
force-pushed
the
cc/unnamed-env-docs
branch
from
d03c2f3
to
df7a202
Compare
carolineechen
force-pushed
the
cc/rename-default-env
branch
from
a4975f0
to
40f1e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after introducing cluster default envs as a property of a cluster, we no longer need a catch all name for all unnamed envs, which can have confusing behavior. rather,
{cluster.name}_default_env(similar to how cluster ssh secrets are automatically named). this is used as the key for the env servlet, and also for purposes of saving the cluster.Cluster.EMPTY_DEFAULT_ENV_NAME = _cluster_default_env, which is part of the cluster class, rather than the env class. this is used as the env servlet key, and not part of the cluster config so will not be saved.