Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env vars in default env creation #798

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

carolineechen
Copy link
Collaborator

No description provided.

Copy link

sentry-io bot commented May 10, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
restart_server ValueError: Error installing runhouse on cluster <dataset_runner> node <209.20.158.103> ...
Event Count: 2
restart_server TypeError: OnDemandCluster._start_ray_workers() got an unexpected keyword argument 'env' ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

@carolineechen carolineechen merged commit 2529b79 into main May 19, 2024
8 of 11 checks passed
@carolineechen carolineechen deleted the cc/default-env-vars branch May 19, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant