Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster status scheduler, move config.yaml creation to restart server() #868

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

BelSasha
Copy link
Contributor

@BelSasha BelSasha commented Jun 4, 2024

Add test to check status ping to den schedluer logic (#862)

Co-authored-by: Alexandra Belousov sashabelousovrh@Alexandras-MacBook-Pro.local

move config.yaml creation to restart_server

Copy link

sentry-io bot commented Jun 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
up TypeError: argument of type 'NoneType' is not iterable gpu.gpu_cluster in ...
Event Count: 2
up TypeError: argument of type 'NoneType' is not iterable main in <m...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor Author

BelSasha commented Jun 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BelSasha and the rest of your teammates on Graphite Graphite

@BelSasha BelSasha changed the title cluster status scheduler tests Fix cluster status scheduler, move config.yaml creation to restart server() Jun 4, 2024
@BelSasha BelSasha force-pushed the sb/move_config_yaml_creation_to_restart_server branch from 0155314 to 5900bbf Compare June 4, 2024 17:16
Add test to check status ping to den schedluer logic (#862)

Co-authored-by: Alexandra Belousov <sashabelousovrh@Alexandras-MacBook-Pro.local>

move config.yaml creation to restart_server
@BelSasha BelSasha force-pushed the sb/move_config_yaml_creation_to_restart_server branch from 5900bbf to 64be704 Compare June 4, 2024 17:25
Copy link
Contributor

dongreenberg commented Jun 4, 2024

Merge activity

@dongreenberg dongreenberg merged commit e8f786e into main Jun 4, 2024
10 of 11 checks passed
@jlewitt1 jlewitt1 deleted the sb/move_config_yaml_creation_to_restart_server branch July 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants