Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify setup in docs and den quick start #876

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mkandler
Copy link
Contributor

@mkandler mkandler commented Jun 7, 2024

Walked through the Llama 3 example and the Den Quick Start and caught a few things, notably:

  • Missing python for conda setup
  • Showing explicit pip install packages, in case you are on /examples and not in the repo
  • Typos in model names
  • Removed some empty code blocks on Den Quick Start + fixed an incorrect function variable name

Copy link
Contributor Author

mkandler commented Jun 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mkandler and the rest of your teammates on Graphite Graphite

@mkandler mkandler force-pushed the 06-07-clarify_setup_in_docs_and_den_quick_start branch from 7200286 to d044f9b Compare June 7, 2024 21:18
@mkandler mkandler merged commit 6b1bfa2 into main Jun 10, 2024
12 checks passed
@mkandler mkandler deleted the 06-07-clarify_setup_in_docs_and_den_quick_start branch June 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants