Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster factory bug with den_auth clusters not being saved. #878

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jun 8, 2024

No description provided.

Copy link

sentry-io bot commented Jun 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster_factory.py

Function Unhandled Issue
ondemand_cluster NameError: name 'sky' is not defined main in ...
Event Count: 2
cluster PermissionError: No Runhouse token provided. Try running $ runhouse login or visiting https://run.house/login to... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor Author

rohinb2 commented Jun 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

@rohinb2 rohinb2 merged commit 8852fe6 into main Jun 9, 2024
12 checks passed
@rohinb2 rohinb2 deleted the 06-08-Fix_cluster_factory_bug_with_den_auth_clusters_not_being_saved branch June 9, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant