Propagate self.env if it was set.
#916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/module.py
Did you find this useful? React with a 👍 or 👎 |
rohinb2
force-pushed
the
06-18-Propagate_self.env_if_it_was_set
branch
2 times, most recently
from
70d26a8
to
a83956c
Compare
This was referenced Jun 19, 2024
carolineechen
approved these changes
Jun 20, 2024
| @@ -30,6 +30,12 @@ def np_summer(a, b): | |||
| return int(np.sum([a, b])) | |||
|
|
|||
|
|
|||
| def torch_import(): | |||
| import torch | |||
There was a problem hiding this comment.
could we use a diff library that's not used in any other test env/function yet to make sure its standalone? aws_cpu fixture now uses a torch docker image
dongreenberg
approved these changes
Jun 20, 2024
rohinb2
force-pushed
the
06-18-Propagate_self.env_if_it_was_set
branch
from
a83956c
to
bc446aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking example, where we initialize
reqsin the constructor, which gets set in the env, but is not propagated in.tobecause the env has no name. Pretty sure we can just sendself.envand later we have a check if it has no name to take a different path.See test for repro.