Fix log statements of port forwarding to actually work. #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 24, 2024
| self.tunnel_proc = None | ||
| self.local_bind_port = None | ||
| self.remote_bind_port = None | ||
|
|
||
| if "ControlMaster" not in port_fwd_cmd: | ||
| return |
There was a problem hiding this comment.
should we also set them to none here too? added this case for docker cluster where the cancel_port_fwd command doesn't work and the tunnel seems to be terminated upon exiting already
rohinb2
force-pushed
the
06-22-Fix_log_statements_of_port_forwarding_to_actually_work
branch
from
d53c25a
to
c66d50e
Compare
rohinb2
force-pushed
the
06-22-Split_off_cluster_tests_into_their_own_test_run
branch
from
168d084
to
7266a53
Compare
Base automatically changed from
06-22-Split_off_cluster_tests_into_their_own_test_run
to
main
June 24, 2024 02:55
rohinb2
force-pushed
the
06-22-Fix_log_statements_of_port_forwarding_to_actually_work
branch
from
c66d50e
to
631f587
Compare
rohinb2
deleted the
06-22-Fix_log_statements_of_port_forwarding_to_actually_work
branch
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.