Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always convert string req to Package object. #966

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jul 3, 2024

No description provided.

Copy link
Contributor Author

rohinb2 commented Jul 4, 2024

Merge activity

  • Jul 4, 10:25 AM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jul 4, 10:33 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 4, 10:34 AM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the 07-03-Move_run_with_logs_into_utils branch from 21e71fd to 9244d1b Compare July 4, 2024 14:30
Base automatically changed from 07-03-Move_run_with_logs_into_utils to main July 4, 2024 14:32
@rohinb2 rohinb2 merged commit 70af932 into main Jul 4, 2024
12 of 13 checks passed
@rohinb2 rohinb2 deleted the package-convert branch July 4, 2024 14:34
Copy link
Contributor

@dongreenberg dongreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting - we did this so when you save an env we don't save dozens of other objects to Den for every pypi package you install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants