fix: by comment about added 'tool' role in messageType

run-llama · Dec 13, 2024 · c81e9a5 · c81e9a5
1 parent 04b4f76
commit c81e9a5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/.changeset/pink-days-appear.md b/.changeset/pink-days-appear.md
@@ -1,8 +1,7 @@
 ---
-"@llamaindex/anthropic": minor
-"@llamaindex/llamaindex-test": minor
-"llamaindex": minor
-"@llamaindex/core": minor
+"@llamaindex/anthropic": patch
+"llamaindex": patch
+"@llamaindex/core": patch
 ---
 
 added support for tool calls with results in message history for athropic agent
diff --git a/packages/core/src/llms/type.ts b/packages/core/src/llms/type.ts
@@ -54,7 +54,7 @@ export interface LLM<
   ): Promise<CompletionResponse>;
 }
 
-export type MessageType = "user" | "assistant" | "system" | "memory" | "tool";
+export type MessageType = "user" | "assistant" | "system" | "memory";
 
 export type TextChatMessage<AdditionalMessageOptions extends object = object> =
   {

diff --git a/packages/llamaindex/src/llm/gemini/utils.ts b/packages/llamaindex/src/llm/gemini/utils.ts
@@ -188,7 +188,6 @@ export class GeminiHelper {
     system: "user",
     assistant: "model",
     memory: "user",
-    tool: "user",
   };
 
   public static readonly ROLES_FROM_GEMINI: Record<

diff --git a/packages/llamaindex/tests/llm/index.test.ts b/packages/llamaindex/tests/llm/index.test.ts
@@ -211,7 +211,7 @@ describe("Message Formatting", () => {
         },
       },
       {
-        role: "tool",
+        role: "assistant",
         content: "The weather in London is sunny, +20°C",
         options: {
           toolResult: {
@@ -276,7 +276,7 @@ describe("Message Formatting", () => {
           ],
         },
         {
-          role: "user",
+          role: "user", // anthropic considers all that comes not from their inference API is user role
           content: [
             {
               type: "tool_result",