fix: by comment about added 'tool' role in messageType

run-llama · Dec 13, 2024 · e4ea830 · e4ea830
1 parent b56a433
commit e4ea830
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/core/src/llms/type.ts b/packages/core/src/llms/type.ts
@@ -54,7 +54,7 @@ export interface LLM<
   ): Promise<CompletionResponse>;
 }
 
-export type MessageType = "user" | "assistant" | "system" | "memory" | "tool";
+export type MessageType = "user" | "assistant" | "system" | "memory";
 
 export type TextChatMessage<AdditionalMessageOptions extends object = object> =
   {

diff --git a/packages/llamaindex/src/llm/gemini/utils.ts b/packages/llamaindex/src/llm/gemini/utils.ts
@@ -188,7 +188,6 @@ export class GeminiHelper {
     system: "user",
     assistant: "model",
     memory: "user",
-    tool: "user",
   };
 
   public static readonly ROLES_FROM_GEMINI: Record<

diff --git a/packages/llamaindex/tests/llm/index.test.ts b/packages/llamaindex/tests/llm/index.test.ts
@@ -276,7 +276,7 @@ describe("Message Formatting", () => {
           ],
         },
         {
-          role: "user",
+          role: "user", // anthropic considers all that comes not from their inference API is user role
           content: [
             {
               type: "tool_result",