refactor: prompt system #1154
refactor: prompt system #1154
Conversation
🦋 Changeset detectedLatest commit: b8dc81a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/core
@llamaindex/community
@llamaindex/experimental
@llamaindex/env
llamaindex
@llamaindex/wasm-tools
commit: |
| @@ -132,7 +146,8 @@ | |||
| "devDependencies": { | |||
| "ajv": "^8.17.1", | |||
| "bunchee": "5.3.2", | |||
| "natural": "^8.0.1" | |||
| "natural": "^8.0.1", | |||
| "python-format-js": "^1.4.3" | |||
There was a problem hiding this comment.
@himself65 I think that the python-format-js should be in dependencies and not in devDependencies.
I'm saying this because it's being used at packages/core/src/prompts/base.ts.
Can you please confirm?
There was a problem hiding this comment.
I intentionally use dev dep to let bundler to inline the code
There was a problem hiding this comment.
@himself65 apologies, my initial comment was probably misleading due to lack of context
I'm developing a next-based app and after bumping llamaindex I started to see the following error:
⨯ TypeError: Cannot redefine property: format
at Function.defineProperty ()
at eval (webpack-internal:///(rsc)/../../node_modules/@llamaindex/core/dist/prompts/index.js:28:8)
at (rsc)/../../node_modules/@llamaindex/core/dist/prompts/index.js (apps/web/.next/server/vendor-chunks/@llamaindex.js:80:1)
at webpack_require (apps/web/.next/server/webpack-runtime.js:33:43)
at eval (webpack-internal:///(rsc)/../../node_modules/llamaindex/dist/index.edge.js:222:82)
at (rsc)/../../node_modules/llamaindex/dist/index.edge.js (apps/web/.next/server/vendor-chunks/llamaindex.js:560:1)
so I assumed that this was the source of the problem.
However, now that I'm investigating a little bit more I'm seeing that problem does not come from this PR. It's something else.
Apologies for tagging you and thank you for quick reply
| @@ -0,0 +1,225 @@ | |||
| import format from "python-format-js"; | |||
There was a problem hiding this comment.
@himself65 this is where python-format-js is being imported
Related issue: #739