Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PostgresKVStore constructor params #1240

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

gorango
Copy link
Contributor

@gorango gorango commented Sep 22, 2024

Allow initializing with pg client or pool instance

Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: 507c3ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
llamaindex Patch
docs Patch
@llamaindex/autotool Patch
@llamaindex/experimental Patch
@llamaindex/cloudflare-worker-agent-test Patch
@llamaindex/next-agent-test Patch
@llamaindex/nextjs-edge-runtime-test Patch
@llamaindex/next-node-runtime-test Patch
@llamaindex/waku-query-engine-test Patch
@llamaindex/autotool-01-node-example Patch
@llamaindex/autotool-02-next-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 5:48pm

Copy link

pkg-pr-new bot commented Sep 22, 2024

Open in Stackblitz

@llamaindex/autotool

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/autotool@1240

@llamaindex/cloud

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/cloud@1240

@llamaindex/community

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/community@1240

@llamaindex/core

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/core@1240

@llamaindex/env

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/env@1240

@llamaindex/experimental

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/experimental@1240

llamaindex

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/llamaindex@1240

@llamaindex/wasm-tools

pnpm add https://pkg.pr.new/run-llama/LlamaIndexTS/@llamaindex/wasm-tools@1240

commit: 507c3ec

@gorango
Copy link
Contributor Author

gorango commented Sep 22, 2024

I also I updated the docStore.utils methods for docToJson and jsonToDoc to allow skipping the calls to parse & stringify when handling doc data in the PostgresDocumentStore since Postgres can store and retrieve raw JSON

@gorango gorango marked this pull request as ready for review September 22, 2024 12:32
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR but I will consider the usage of nativeJson here

@gorango
Copy link
Contributor Author

gorango commented Sep 22, 2024

I have reverted the JSON changes as they are not directly related to this PR.

I opened a separate PR for the JSON bit. My rationale is:

  • storing the raw JSON allows querying in pg and
  • there are performance benefits in avoiding the additional steps involved in parse/stringify especially with large objects.

@himself65 himself65 merged commit 025ffe6 into run-llama:main Sep 23, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants