set typedoc revision to main #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory this will stop the API docs thrashing on every build. Of course, there is a drawback in that if main changes but we haven't released a new version of the docs yet the links will go out of date. So longer term we might want to investigate some kind of variable where we can continue to have up to date revs but keep the rev in a single variable somewhere: facebook/docusaurus#395 In the meantime much smaller commits will be a relief
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
(not so) hilarious thing: I just checked the deployments and for all the thrashing we were doing to the git commits the links weren't even making it into the final API docs. Even though they're in the .md files something strips the github links out at the end. Not going to investigate because it's probably for the best anyways. |
|
Going to merge now (huge QoL issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory this will stop the API docs thrashing on every build.
Of course, there is a drawback in that if main changes but we haven't released a new version of the docs yet the links will go out of date.
So longer term we might want to investigate some kind of variable where we can continue to have up to date revs but keep the rev in a single variable somewhere:
facebook/docusaurus#395
In the meantime much smaller commits will be a relief