fix: setDocumentHash should be async #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 326a1f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
himself65
reviewed
May 22, 2024
|
himself65
approved these changes
May 22, 2024
himself65
force-pushed
the
fix/async-set-hash
branch
from
d6b448e to
ab0c7cb
Compare
pserrer1
force-pushed
the
fix/async-set-hash
branch
from
ab0c7cb to
326a1f9
Compare
Comment on lines
+2
to
+3
| "llamaindex": minor | ||
| "docs": minor |
There was a problem hiding this comment.
@himself65 i wouldn't use minor
There was a problem hiding this comment.
didn't see that, let me change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if used as an async function in multiple places the current implementation of setDocumentHash isn't declared that way.
This PR fixes this issue