-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ReAct agent chat engine with context generator #881
feat: ReAct agent chat engine with context generator #881
Conversation
🦋 Changeset detectedLatest commit: 255f1e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
06fcf21
to
e6544b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please rebase the code?
@parhammmm did you compare this approach with using a
|
@marcusschiesser I actually did and have moved to using that approach, I made the engine for it on my local I can make a PR Might be worth while not to merge in this PR because of it |
e6544b3
to
255f1e7
Compare
@marcusschiesser having said that it does have a use case, when you need things that should always be called e.g. attachments lookups and you don't want to fiddle with the prompting of the agent. Will still make the AgentChatEngine pr shortly @himself65 rebased |
@parhammmm how about using then a design where you just plugin the |
@marcusschiesser we can just go ahead and abandon this PR in favour of #909 ? |
@parhammmm just reviewed #909 - but the use case of this PR is to add a |
@marcusschiesser @himself65 closing this in favour of the recent PRs |
This enables tool calling within a conversation + RAG enabled.
example usage: