refactor: unify response and agent response #930
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0899592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| sources: ToolOutput[]; | ||
| }; | ||
|
|
||
| export type AgentChatResponse<Options extends object> = { |
There was a problem hiding this comment.
AgentChatResponse is better than Response but most people are using normal chat engines I assume, so we better improve the existing Response class (see above)
packages/core/src/Response.ts
Outdated
| * Response is the output of a LLM | ||
| */ | ||
| export class Response { | ||
| export class Response implements ChatResponse { |
There was a problem hiding this comment.
Idea: we include message and raw from ChatResponse instead of adding chatResponse: ChatResponse as an attribute to Response
Note: we ChatResponse supports extension with Options we have to add this to this PR (after we agree on the contract)
There was a problem hiding this comment.
another advantage is that Reponse behaves like ChatReponse
There was a problem hiding this comment.
TBD: how to deal with chunks? We have ChatReponseChunks as type returned by LLMs but chat engines are just streaming Response objects.
Suggestion: we add an optional delta attribute to Response
packages/core/src/Response.ts
Outdated
| */ | ||
| export class Response { | ||
| export class Response implements ChatResponse { | ||
| // @deprecated use 'message' instead |
There was a problem hiding this comment.
we tell the user to not use response instead migrate to message
packages/core/src/Response.ts
Outdated
| * Response is the output of a LLM | ||
| */ | ||
| export class Response { | ||
| export class Response implements ChatResponse { |
There was a problem hiding this comment.
could we don't naming Response it's already a Web API
There was a problem hiding this comment.
how about EngineResponse (see new code)?
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "llamaindex": minor | |||
There was a problem hiding this comment.
@himself65 minor because agent chat interface is breaking
| message: "What is the weather in San Francisco?", | ||
| }); | ||
| consola.debug("response:", response.message.content); | ||
|
|
||
| strictEqual(sources.length, 1); |
There was a problem hiding this comment.
@himself65 i removed sources (the tooloutput) 1. the name is confusing 2. it can be retrieved with events
No description provided.