Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to nextjs 15 #147

Closed
wants to merge 2 commits into from
Closed

feat: upgrade to nextjs 15 #147

wants to merge 2 commits into from

Conversation

thucpn
Copy link
Collaborator

@thucpn thucpn commented Jun 27, 2024

Follow upgrade guides:
https://rc.nextjs.org/docs/app/building-your-application/upgrading/version-15
https://react.dev/blog/2024/04/25/react-19-upgrade-guide

Summary by CodeRabbit

  • New Features

    • Upgraded to Next.js 15, improving overall application functionality.
  • Configuration Changes

    • Moved serverComponentsExternalPackages from experimental to the top-level serverExternalPackages in next.config.json.
    • Added sharp and onnxruntime-node to serverExternalPackages.
  • Dependency Updates

    • Updated multiple dependencies to their latest versions, including react, next, typescript, eslint, prettier, and more.
  • Build Enhancements

    • Added canvas as an external dependency in the webpack configuration.

@thucpn thucpn requested a review from marcusschiesser June 27, 2024 08:54
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: c17351b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-llama Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Jun 27, 2024

Walkthrough

The update significantly modernizes the Next.js project by upgrading to Next.js 15 and refreshing many dependencies, ensuring better compatibility and features. Configuration changes have been applied for improved server handling, and external dependencies are streamlined for enhanced performance.

Changes

File Path Summary
.changeset/curly-eyes-rest.md Provides a summary of the Next.js upgrade and other changes.
templates/types/streaming/nextjs/next.config.json Moved serverComponentsExternalPackages to a new top-level key serverExternalPackages.
templates/types/streaming/nextjs/package.json Updated multiple dependencies: @radix-ui/react-*, next, react, tailwind-merge, etc.
templates/types/streaming/nextjs/webpack.config.mjs Added canvas: "commonjs canvas" to external dependencies.

Note: Dependencies in package.json are upgraded to newer versions, improving overall application performance and feature set.

Poem

In the code where updates flow,
Next.js 15 began to glow.
Sharp and onnxruntime, now aligned,
External packages, redefined.
Dependencies dance, freshly renewed,
The rabbit cheers, oh what a view!

Let projects thrive, as change takes flight,
In lines of code, by day and night. 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 588e0d6 and c17351b.

Files selected for processing (4)
  • .changeset/curly-eyes-rest.md (1 hunks)
  • templates/types/streaming/nextjs/next.config.json (1 hunks)
  • templates/types/streaming/nextjs/package.json (2 hunks)
  • templates/types/streaming/nextjs/webpack.config.mjs (1 hunks)
Files skipped from review due to trivial changes (2)
  • .changeset/curly-eyes-rest.md
  • templates/types/streaming/nextjs/webpack.config.mjs
Additional comments not posted (4)
templates/types/streaming/nextjs/next.config.json (1)

7-7: Configuration change is aligned with Next.js 15 upgrade.

The serverExternalPackages configuration has been correctly updated to reflect the new requirements for Next.js 15. Make sure that all server-side external packages are correctly listed here for proper functioning.

templates/types/streaming/nextjs/package.json (3)

47-62: Updates to development dependencies.

The updates to TypeScript, ESLint, Prettier, and other development tools are crucial for maintaining code quality and compatibility with the latest standards. Verify that the new configurations do not introduce linting or build errors.


16-18: Dependencies updated to latest versions.

The updates for @radix-ui/react-collapsible, @radix-ui/react-hover-card, and @radix-ui/react-slot are consistent with the latest available versions. Ensure these updates do not introduce breaking changes by running comprehensive tests.


29-32: Major version upgrades for Next.js and React.

Upgrading to Next.js 15.0.0-rc.0 and React 19.0.0-rc are major changes. Thoroughly test the application to ensure compatibility and stability, especially since these are release candidates.

@thucpn
Copy link
Collaborator Author

thucpn commented Jun 27, 2024

Deprecated dependencies:

$ pnpm i
WARN 10 deprecated subdependencies found: @humanwhocodes/config-array@0.11.14, @humanwhocodes/object-schema@2.0.3, are-we-there-yet@2.0.0, dommatrix@1.0.3, fs-promise@2.0.3, gauge@3.0.2, glob@7.2.3, inflight@1.0.6, npmlog@5.0.1, rimraf@3.0.2
Already up to date
Progress: resolved 1056, reused 1007, downloaded 0, added 0, done
WARN Issues with peer dependencies found
.
├─┬ @llamaindex/pdf-viewer 1.1.1
│ ├─┬ @wojtekmaj/react-hooks 1.17.2
│ │ └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│ ├─┬ react-intersection-observer 9.5.1
│ │ └── ✕ unmet peer react@"^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│ ├─┬ react-pdf 6.2.2
│ │ ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│ │ └── ✕ unmet peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│ └─┬ react-window 1.8.9
│   ├── ✕ unmet peer react@"^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│   └── ✕ unmet peer react-dom@"^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625        
├─┬ ai 3.2.11
│ └─┬ @ai-sdk/react 0.0.11
│   └─┬ swr 2.2.0
│     ├── ✕ unmet peer react@"^16.11.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│     └─┬ use-sync-external-store 1.2.2
│       └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
├─┬ lucide-react 0.294.0
│ └── ✕ unmet peer react@"^16.5.1 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
├─┬ next 15.0.0-rc.0
│ ├── ✕ unmet peer react@19.0.0-rc-f994737d14-20240522: found 19.0.0-rc-8971381549-20240625
│ └── ✕ unmet peer react-dom@19.0.0-rc-f994737d14-20240522: found 19.0.0-rc-8971381549-20240625
├─┬ vaul 0.9.1
│ ├── ✕ unmet peer react@"^16.8 || ^17.0 || ^18.0": found 19.0.0-rc-8971381549-20240625
│ ├── ✕ unmet peer react-dom@"^16.8 || ^17.0 || ^18.0": found 19.0.0-rc-8971381549-20240625
│ └─┬ @radix-ui/react-dialog 1.1.1
│   └─┬ react-remove-scroll 2.5.7
│     ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│     ├─┬ react-remove-scroll-bar 2.3.6
│     │ ├── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│     │ └─┬ react-style-singleton 2.2.1
│     │   └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│     ├─┬ use-callback-ref 1.3.2
│     │ └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
│     └─┬ use-sidecar 1.1.2
│       └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0-rc-8971381549-20240625
└─┬ llamaindex 0.4.3
  └─┬ chromadb 1.8.1
    └── ✕ unmet peer @google/generative-ai@^0.1.1: found 0.12.0

@@ -9,6 +9,7 @@ export default function webpack(config) {
config.externals.push({
"onnxruntime-node": "commonjs onnxruntime-node",
sharp: "commonjs sharp",
canvas: "commonjs canvas",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is that coming from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there's one dependency using that canvas package and has parse failed error.
Similar issue: wojtekmaj/react-pdf#1508

@marcusschiesser marcusschiesser marked this pull request as draft June 27, 2024 11:51
@marcusschiesser
Copy link
Collaborator

Not releasing yet, waiting for the other packages to use react 19

@marcusschiesser
Copy link
Collaborator

already did nextjs 15 update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants