-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to nextjs 15 #147
Conversation
🦋 Changeset detectedLatest commit: c17351b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe update significantly modernizes the Next.js project by upgrading to Next.js 15 and refreshing many dependencies, ensuring better compatibility and features. Configuration changes have been applied for improved server handling, and external dependencies are streamlined for enhanced performance. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .changeset/curly-eyes-rest.md (1 hunks)
- templates/types/streaming/nextjs/next.config.json (1 hunks)
- templates/types/streaming/nextjs/package.json (2 hunks)
- templates/types/streaming/nextjs/webpack.config.mjs (1 hunks)
Files skipped from review due to trivial changes (2)
- .changeset/curly-eyes-rest.md
- templates/types/streaming/nextjs/webpack.config.mjs
Additional comments not posted (4)
templates/types/streaming/nextjs/next.config.json (1)
7-7
: Configuration change is aligned with Next.js 15 upgrade.The
serverExternalPackages
configuration has been correctly updated to reflect the new requirements for Next.js 15. Make sure that all server-side external packages are correctly listed here for proper functioning.templates/types/streaming/nextjs/package.json (3)
47-62
: Updates to development dependencies.The updates to TypeScript, ESLint, Prettier, and other development tools are crucial for maintaining code quality and compatibility with the latest standards. Verify that the new configurations do not introduce linting or build errors.
16-18
: Dependencies updated to latest versions.The updates for
@radix-ui/react-collapsible
,@radix-ui/react-hover-card
, and@radix-ui/react-slot
are consistent with the latest available versions. Ensure these updates do not introduce breaking changes by running comprehensive tests.
29-32
: Major version upgrades for Next.js and React.Upgrading to
Next.js 15.0.0-rc.0
andReact 19.0.0-rc
are major changes. Thoroughly test the application to ensure compatibility and stability, especially since these are release candidates.
Deprecated dependencies:
|
@@ -9,6 +9,7 @@ export default function webpack(config) { | |||
config.externals.push({ | |||
"onnxruntime-node": "commonjs onnxruntime-node", | |||
sharp: "commonjs sharp", | |||
canvas: "commonjs canvas", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is that coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC there's one dependency using that canvas package and has parse failed error.
Similar issue: wojtekmaj/react-pdf#1508
Not releasing yet, waiting for the other packages to use react 19 |
already did nextjs 15 update |
Follow upgrade guides:
https://rc.nextjs.org/docs/app/building-your-application/upgrading/version-15
https://react.dev/blog/2024/04/25/react-19-upgrade-guide
Summary by CodeRabbit
New Features
Configuration Changes
serverComponentsExternalPackages
fromexperimental
to the top-levelserverExternalPackages
innext.config.json
.sharp
andonnxruntime-node
toserverExternalPackages
.Dependency Updates
react
,next
,typescript
,eslint
,prettier
, and more.Build Enhancements
canvas
as an external dependency in the webpack configuration.