fix: bump llama-index-callbacks-arize-phoenix package

[leehuwuj]

Fix: #338

Summary by CodeRabbit

• New Features

  • Introduced observability options for Python dependency resolution, enhancing tracking capabilities.
  • Added a new test suite for observability options in the dependency resolution process.

• Bug Fixes

  • Updated the version of a key dependency to improve functionality.

• Refactor

  • Consolidated project creation logic into a dedicated function for better clarity and maintainability.

[changeset-bot]

🦋 Changeset detected

Latest commit: bb3c4b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-llama	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

The pull request introduces enhancements to the observability features within the package, particularly focusing on the "llamatrace" functionality. It updates the RunCreateLlamaOptions type to include observability parameters and modifies the test suite to add tests that verify the behavior of Python dependency resolution with these options. Additionally, it updates the version of a specific dependency to resolve conflicts identified in linked issues.

Changes

File	Change Summary
.changeset/perfect-bags-greet.md	Introduces a patch labeled "create-llama" for observability updates related to "llamatrace."
e2e/python/resolve_dependencies.spec.ts	Adds tests for observability options, modifies existing tests, and introduces createAndCheckLlamaProject function.
e2e/utils.ts	Updates RunCreateLlamaOptions to include an optional observability property and modifies runCreateLlama function signature.
helpers/python.ts	Updates version of llama-index-callbacks-arize-phoenix from ^0.1.6 to ^0.2.1 within installPythonTemplate.

Assessment against linked issues

Objective	Addressed	Explanation
Update dependency version to resolve conflict with llama-index (338)	✅

Possibly related PRs

• feat: add LlamaTrace support #216: Introduces support for LlamaTrace, directly related to the observability enhancements.
• feat: add test and fix python dependencies #304: Adds tests and fixes Python dependencies, aligning with the focus on observability and dependency management.
• fix: add dependencies for pg vector store #312: Addresses missing dependencies for the PGVectorStore, relevant to overall dependency management improvements.
• feat: add test deps for llamaparse #323: Adds test dependencies for llamaparse, relevant to the testing enhancements discussed.

Suggested reviewers

• thucpn

🐇 In the meadow, where the llamas play,
Observability blooms in a bright new way.
With dependencies fixed, our paths align,
In the world of code, everything will shine!
Let's hop along, with tests that are keen,
For a future so bright, it's a coder's dream! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

e2e/utils.ts (1)

119-121: LGTM with a minor suggestion: Implementation of observability parameter

The implementation of the observability parameter is correct and aligns with the PR objectives. However, there's a minor inconsistency that could be addressed:

Consider removing or updating line 103:

"--observability",
"none",

This line sets a default value of "none" for observability, which might conflict with the new conditional block. You could either remove these lines or update the condition to:

if (observability && observability !== "none") {
  commandArgs.push("--observability", observability);
}

This ensures consistency between the default behavior and the new implementation.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 51dc0e4 and bb3c4b9.

📒 Files selected for processing (4)

• .changeset/perfect-bags-greet.md (1 hunks)
• e2e/python/resolve_dependencies.spec.ts (3 hunks)
• e2e/utils.ts (3 hunks)
• helpers/python.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/perfect-bags-greet.md

🔇 Additional comments (12)

e2e/utils.ts (3)

36-36: LGTM: Addition of observability property

The addition of the optional observability property to RunCreateLlamaOptions is well-implemented. It aligns with the PR objectives by allowing for configuration of observability settings, while maintaining backward compatibility by being optional.

---

54-54: LGTM: Addition of observability parameter

The addition of the observability parameter to the runCreateLlama function signature is consistent with the changes to RunCreateLlamaOptions. It's correctly placed at the end of the parameter list, maintaining backward compatibility.

---

Line range hint 1-214: Overall assessment: Changes implement observability option, but don't directly address dependency conflict

The changes in this file successfully implement the addition of an observability option to the create-llama command. This aligns with part of the PR objectives related to enhancing the project's functionality.

However, it's important to note that these changes don't directly address the dependency conflict mentioned in the PR objectives (specifically, the issue with llama-index-callbacks-arize-phoenix and llama-index versions).

To ensure that the dependency conflict has been resolved, please run the following script:

This script will help verify if the dependency conflict has been resolved by checking for version updates and attempting to install the dependencies.

helpers/python.ts (1)

466-466: LGTM: Version update addresses dependency conflict.

The update of llama-index-callbacks-arize-phoenix from ^0.1.6 to ^0.2.1 directly addresses the dependency conflict mentioned in issue #338. This change should resolve the version solving failure during poetry install.

To ensure this change resolves the issue, please run the following verification steps:

1. Initialize a new project with npx create-llama.
2. Choose the Python backend and Next.js frontend with llama-trace for observability.
3. Run poetry install in the generated project directory.

If the installation completes without errors, it confirms that the dependency conflict has been resolved.

e2e/python/resolve_dependencies.spec.ts (8)

7-7: Imports are appropriate and necessary

The imported modules are correctly used in the code, ensuring type safety and functionality.

---

45-46: Observability options are properly defined

The observabilityOptions array is correctly initialized with the desired observability options.

---

47-74: New observability tests are well-structured

The added test suite correctly iterates over observability options and invokes the tests with the appropriate configurations.

---

81-81: Tool description variable enhances test readability

The toolDescription variable improves the clarity of test descriptions, making the test outputs more informative.

---

82-82: Option description improves test clarity

The optionDescription variable concisely summarizes the test parameters, enhancing test output readability.

---

87-105: Refactoring enhances code maintainability

Using the createAndCheckLlamaProject function encapsulates common logic, improving code reuse and maintainability.

---

107-107: Comment improves code clarity

The added comment clearly indicates the purpose of the subsequent code block.

---

146-180: createAndCheckLlamaProject function is well-designed

The new function encapsulates project creation and validation logic, enhancing modularity and reusability of the code.

[marcusschiesser]

@leehuwuj how about we run not each combination but just first all vec dbs, then all tools and then all DS?