feat: Add legal document review use case #467

leehuwuj · 2024-12-23T05:30:16Z

No description provided.

changeset-bot · 2024-12-23T05:30:19Z

⚠️ No Changeset found

Latest commit: 22b2992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2024-12-23T05:30:24Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

helpers/datasources.ts

leehuwuj · 2024-12-23T05:39:46Z

helpers/index.ts

@@ -192,7 +193,7 @@ export const installTemplate = async (
    if (
      props.template === "streaming" ||
      props.template === "multiagent" ||
-      props.template === "extractor"
+      props.template === "reflex"


Changed to reflex for sharing reflex code, the specified code for each use case moved to component/agents folder; as reflex is only for python so it's a bit tricky, also welcome for better ideas.

how about just storing those components in components/reflex? as we might do something non-agent?

Updated! But it's a bit weird that using agents value for the reflex. May be we can change the agents param to useCase?

leehuwuj · 2024-12-23T05:42:29Z

templates/components/agents/python/contract_review/app/ui/states/workflow.py

+    output: Optional[Dict[str, Any]]
+
+
+class GuidelineHandlerState(rx.State):


As the guideline step has a nested data but Reflex is really hard to handle state with complex data so i split it into two models: GuidelineState and GuidelineHandlerState

helpers/python.ts

marcusschiesser · 2024-12-23T08:03:21Z

questions/questions.ts

-      program.useLlamaParse === undefined &&
-      program.template !== "extractor"
-    ) {
+    // Reflex template doesn't support LlamaParse and LlamaCloud right now (cannot use asyncio loop in Reflex)


@leehuwuj please add a ticket for this if we continue using more reflex with this PR

Sure, I think it's worth logging a ticket for it: #468

marcusschiesser · 2024-12-23T08:04:27Z

questions/simple.ts

@@ -51,7 +57,7 @@ export const askSimpleQuestions = async (
  let llamaCloudKey = args.llamaCloudKey;
  let useLlamaCloud = false;

-  if (appType !== "extractor") {
+  if (appType !== "extractor" && appType !== "contract_review") {


why not just?

Suggested change

if (appType !== "extractor" && appType !== "contract_review") {

if (template !== "reflex") {

we don't have template value here, it's mapped later from the appType

marcusschiesser · 2024-12-23T08:06:35Z

helpers/index.ts

@@ -192,7 +193,7 @@ export const installTemplate = async (
    if (
      props.template === "streaming" ||
      props.template === "multiagent" ||
-      props.template === "extractor"
+      props.template === "reflex"


how about just storing those components in components/reflex? as we might do something non-agent?

a crazy refactor

2f155c3

leehuwuj commented Dec 23, 2024

View reviewed changes

fix test

49a7bbc

marcusschiesser reviewed Dec 23, 2024

View reviewed changes

leehuwuj added 5 commits December 23, 2024 15:16

update e2e test

447a509

move reflex code to components/reflex

5b331d5

fix e2e

96ae027

remove redundant code and add readme

0020025

improve contract review code

22b2992

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add legal document review use case #467

feat: Add legal document review use case #467

leehuwuj commented Dec 23, 2024

changeset-bot bot commented Dec 23, 2024 •

edited

Loading

coderabbitai bot commented Dec 23, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

leehuwuj Dec 23, 2024

marcusschiesser Dec 23, 2024

leehuwuj Dec 23, 2024

leehuwuj Dec 23, 2024

marcusschiesser Dec 23, 2024

leehuwuj Dec 23, 2024

marcusschiesser Dec 23, 2024

leehuwuj Dec 23, 2024

marcusschiesser Dec 23, 2024

		output: Optional[Dict[str, Any]]


		class GuidelineHandlerState(rx.State):

	if (appType !== "extractor" && appType !== "contract_review") {
	if (template !== "reflex") {

feat: Add legal document review use case #467

Are you sure you want to change the base?

feat: Add legal document review use case #467

Conversation

leehuwuj commented Dec 23, 2024

changeset-bot bot commented Dec 23, 2024 • edited Loading

⚠️ No Changeset found

coderabbitai bot commented Dec 23, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Dec 23, 2024 •

edited

Loading