fix: init messages memory in start event handler

[thucpn]

Summary by CodeRabbit

• Refactor
  • Simplified workflow initialization processes for both code and document generation workflows.
  • Improved handling of chat history by explicitly setting it at the start of each workflow.
  • Removed redundant parameters and streamlined internal logic for a more consistent user experience.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1d3f343

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes refactor workflow initialization in both the code generator and document generator modules. The wrapper async workflowFactory functions are removed, and the main workflow creation functions are renamed and simplified. Optional LLM parameters are eliminated, with LLM instances now consistently sourced from Settings.llm. Chat history handling is moved to the event handler.

Changes

File(s)	Change Summary
.../code_generator/src/app/workflow.ts .../document_generator/src/app/workflow.ts	Removed wrapper async workflowFactory function; renamed and simplified main workflow creation function; removed optional LLM parameter; chat history is now managed in the event handler rather than during memory initialization; updated event handler destructuring.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WorkflowFactory
    participant Settings
    participant MemoryBuffer

    User->>WorkflowFactory: Call workflowFactory(reqBody)
    WorkflowFactory->>Settings: Get llm instance
    WorkflowFactory->>MemoryBuffer: Initialize empty buffer with llm
    User->>WorkflowFactory: startAgentEvent({userInput, chatHistory})
    WorkflowFactory->>MemoryBuffer: Set chatHistory
    WorkflowFactory->>MemoryBuffer: Add userInput message

Loading

Poem

In the warren of code, a change takes root,
No more wrappers—just direct pursuit!
LLMs from Settings, chat memories anew,
Streamlined the workflow for a cleaner view.
With every hop, our logic grows neat—
Refactored and nimble, it’s quite the feat!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between afe9e9f and 1d3f343.

📒 Files selected for processing (2)

• packages/create-llama/templates/components/use-cases/typescript/code_generator/src/app/workflow.ts (2 hunks)
• packages/create-llama/templates/components/use-cases/typescript/document_generator/src/app/workflow.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: python (20, 3.11, windows-latest, fastapi, --example-file, streaming)

🔇 Additional comments (8)

packages/create-llama/templates/components/use-cases/typescript/document_generator/src/app/workflow.ts (4)

2-2: Improved import statement

The import statement has been simplified to include only the necessary imports from the llamaindex package.

---

71-73: Function refactoring looks good

The function has been renamed to workflowFactory and simplified by obtaining the LLM instance directly from Settings.llm instead of accepting an optional parameter. This makes the code more consistent and maintainable.

---

76-76: Improved memory initialization

The ChatMemoryBuffer is now instantiated without chat history, which will be set explicitly in the event handler instead. This separation of concerns makes the code more maintainable.

---

82-92: Properly initializing chat history in event handler

This is the core fix for the issue mentioned in the PR title. Chat history is now:

1. Destructured from event data with a default empty array
2. Explicitly set in the memory buffer before adding the user input
3. This prevents any issues with chat history initialization

This change ensures that the memory buffer is correctly populated with the chat history from the request.

packages/create-llama/templates/components/use-cases/typescript/code_generator/src/app/workflow.ts (4)

2-2: Improved import statement

The import statement has been simplified to include only the necessary imports from the llamaindex package.

---

68-70: Function refactoring looks good

The function has been renamed to workflowFactory and simplified by obtaining the LLM instance directly from Settings.llm instead of accepting an optional parameter. This makes the code more consistent and maintainable.

---

73-73: Improved memory initialization

The ChatMemoryBuffer is now instantiated without chat history, which will be set explicitly in the event handler instead. This separation of concerns makes the code more maintainable.

---

79-89: Properly initializing chat history in event handler

This is the core fix for the issue mentioned in the PR title. Chat history is now:

1. Destructured from event data with a default empty array
2. Explicitly set in the memory buffer before adding the user input
3. This prevents any issues with chat history initialization

This change ensures that the memory buffer is correctly populated with the chat history from the request.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.