Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create path to config dir if does not exist #480

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: create path to config dir if does not exist #480

merged 1 commit into from
Mar 7, 2025
+10 −0

Conversation

masci
Copy link
Member

@masci masci commented Mar 7, 2025

The config path returned by platformdirs might not exist (the most likely scenario in docker containers), make sure we create the full path to the default config file when the CLI runs for the first time.

@coveralls
Copy link

Coverage Status

coverage: 82.428% (+0.006%) from 82.422%
when pulling c5f7715 on massi/fix-config-path
into 7957800 on main.

logan-markewich
logan-markewich approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit c3fa3c1 into main Mar 7, 2025
31 checks passed
@masci masci deleted the massi/fix-config-path branch March 7, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @coveralls @logan-markewich