Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: update tenacity to 9.0.0 to fix conflict with GraphRAG #16876

Closed
eriklee1895 opened this issue Nov 8, 2024 · 5 comments
Closed
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized

Comments

@eriklee1895
Copy link

Feature Description

When my project use llama-index and GraphRAG, there is a tenacity depends:

The conflict is caused by:
    graphrag 0.4.0 depends on tenacity<10.0.0 and >=9.0.0
    llama-index-core 0.11.22 depends on tenacity!=8.4.0, <9.0.0 and >=8.2.0

Here are the release notes for tenacity 9 (https://github.com/jd/tenacity/releases/tag/9.0.0)
And I found langchain has already updated tenacity version:
langchain-ai/langchain#27201

Now, I wish llama-index can do the same change.

Reason

My project is used GraphRAG and llamaindex both, and now the depends has tenacity conflict.

Value of Feature

No response

@eriklee1895 eriklee1895 added enhancement New feature or request triage Issue needs to be triaged/prioritized labels Nov 8, 2024
@lalitlal
Copy link

lalitlal commented Nov 8, 2024

  • 1, this is also causing issue with Instructor python package.

@qedpi
Copy link

qedpi commented Nov 13, 2024

+1 for instructor

@19920716
Copy link

19920716 commented Dec 4, 2024

+1

@Digma
Copy link
Contributor

Digma commented Dec 4, 2024

+1 would be super helpful for us as well

@eriklee1895
Copy link
Author

I found the problem has been solved in 33ca8d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized
Projects
None yet
Development

No branches or pull requests

5 participants