-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[patch],langchain[patch],community[patch]: Bump version dependency of tenacity to >=8.1.0,!=8.4.0,<10 #27201
Conversation
This fixes the compatiblity issue with graprag as in - langchain-ai#25595 Signed-off-by: Zihao Diao <hi@ericdiao.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide an upper pin everywhere? You can specify it like this: >=8.1.0,<10
We're following semver for dependency specification.
It's generally better to have the library fail to install like here: #25595
than to fail at run time due to a subtle breaking change
Thanks @EricDiao , happy to merge but we need to maintain an upper bound (e.g., <10) to make sure. If you're doing a bump in a library, it's good to review what the breaking change was. In this case, this looks safe (https://github.com/jd/tenacity/releases/tag/9.0.0) -- this is good information to include with the PR |
Signed-off-by: Zihao Diao <hi@ericdiao.com>
Failing unit tests I'll investigate tomorrow |
I am also looking at reproduce the failed tests. |
Signed-off-by: Zihao Diao <hi@ericdiao.com>
Head branch was pushed to by a user without write access
Thanks -- had to resolve merge conflicts on community, pushed an update |
This should fixes the compatibility issue with graprag as in
Here are the release notes for tenacity 9 (https://github.com/jd/tenacity/releases/tag/9.0.0)