Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch],langchain[patch],community[patch]: Bump version dependency of tenacity to >=8.1.0,!=8.4.0,<10 #27201

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

EricDiao
Copy link
Contributor

@EricDiao EricDiao commented Oct 8, 2024

This should fixes the compatibility issue with graprag as in

Here are the release notes for tenacity 9 (https://github.com/jd/tenacity/releases/tag/9.0.0)

This fixes the compatiblity issue with graprag as in

- langchain-ai#25595

Signed-off-by: Zihao Diao <hi@ericdiao.com>
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:00pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Oct 8, 2024
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an upper pin everywhere? You can specify it like this: >=8.1.0,<10

We're following semver for dependency specification.

It's generally better to have the library fail to install like here: #25595

than to fail at run time due to a subtle breaking change

@eyurtsev eyurtsev self-assigned this Oct 8, 2024
@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 8, 2024

Thanks @EricDiao , happy to merge but we need to maintain an upper bound (e.g., <10) to make sure.

If you're doing a bump in a library, it's good to review what the breaking change was. In this case, this looks safe (https://github.com/jd/tenacity/releases/tag/9.0.0) -- this is good information to include with the PR

@eyurtsev eyurtsev added Ɑ: core Related to langchain-core langchain Related to the langchain package labels Oct 8, 2024
Signed-off-by: Zihao Diao <hi@ericdiao.com>
@EricDiao
Copy link
Contributor Author

EricDiao commented Oct 8, 2024

@eyurtsev Thanks!

I added upper version pin in 5c3fea6.

@EricDiao EricDiao changed the title Langchain: Bump version dependency of tenacity to >=8.1.0,!=8.4.0 Langchain: Bump version dependency of tenacity to >=8.1.0,!=8.4.0,<10 Oct 8, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 8, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) October 8, 2024 20:37
@eyurtsev eyurtsev disabled auto-merge October 8, 2024 20:37
@eyurtsev eyurtsev changed the title Langchain: Bump version dependency of tenacity to >=8.1.0,!=8.4.0,<10 core[patch],langchain[patch],community[patch]: Bump version dependency of tenacity to >=8.1.0,!=8.4.0,<10 Oct 8, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) October 8, 2024 20:38
@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 8, 2024

Failing unit tests I'll investigate tomorrow

@EricDiao
Copy link
Contributor Author

EricDiao commented Oct 8, 2024

I am also looking at reproduce the failed tests.

Signed-off-by: Zihao Diao <hi@ericdiao.com>
auto-merge was automatically disabled October 9, 2024 00:11

Head branch was pushed to by a user without write access

@EricDiao
Copy link
Contributor Author

EricDiao commented Oct 9, 2024

@eyurtsev I merged changes on master back in 538e8cb. It works now on my local testbed. You may want to trigger the CI again.

@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 9, 2024

Thanks -- had to resolve merge conflicts on community, pushed an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants