Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug on vector_search_profile default(this profile did not exist) and add the possibility to choose language_analyzer of searchable fields, now on v0.10.3 format #10675

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ryanrib14
Copy link
Contributor

Description

I changed the selection of the vector_search_profile that was previously set as "default" behind the scenes but this profile did not exist in the defaults that were defined causing an error when creating the index, so I added the possibility for the user to choose between the two available profiles' myHnsw' and 'myExhaustiveKnn'. Furthermore, as I am a Brazilian developer I was facing performance problems with the default language analyzer in searchable fields which was defined as "en.lucene" so I added the possibility for the user to choose which one is best for their case and documents language.
the list of analyzers:https://learn.microsoft.com/en-us/azure/search/index-add-language-analyzers

I also suggest that in a next PR add the possibility of choosing the similarity metric, update the notebooks to work without service context etc, can i make this, but is better that this PR be merge first.

Fixes #10522

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I ran the existing notebook testing the modifications "AzureAISearchIndexDemo.ipynb"
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

…st) and add the possibility to choose language_analyzer of searchable fields, now on v0.10.3 format
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2024
@hatianzhang hatianzhang merged commit f4bcb31 into run-llama:main Feb 13, 2024
8 checks passed
Rana-Banerjee pushed a commit to Rana-Banerjee/llama_index that referenced this pull request Feb 14, 2024
…st) and add the possibility to choose language_analyzer of searchable fields, now on v0.10.3 format (run-llama#10675)
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
…st) and add the possibility to choose language_analyzer of searchable fields, now on v0.10.3 format (run-llama#10675)
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
…st) and add the possibility to choose language_analyzer of searchable fields, now on v0.10.3 format (run-llama#10675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Azure AI search UnkownVectorAlgorithmConfiguration
2 participants