Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira personal access token with hosted instances #13890

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

gsuriano
Copy link
Contributor

@gsuriano gsuriano commented Jun 1, 2024

Description

This pull requests adds the functionality to use the Personal Acces Token for a specified server_url of a hosted Jira issue.
The two already available methods allow the user to read with BasicAuth and Oauth2, but there is also a third case that I experienced at company work. In this way specifying a dictionary with server_url and token_api it's possible to use the Jira API with this third model.
I provide a github issue answer to the related topic (from Jira API repo) pycontribs/jira#989 (comment)
Where it is explained how to access with Personal Access Token in this case

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No (not needed)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (added explanation on Readme.md)
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 4, 2024
@logan-markewich logan-markewich merged commit 91c90e0 into run-llama:main Jun 4, 2024
8 checks passed
Mateusz-Switala pushed a commit to Mateusz-Switala/llama_index that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants