Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Add configurable timeout to LLM retry decorator #17755

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ramarnat
Copy link
Contributor

@ramarnat ramarnat commented Feb 8, 2025

feat: Add configurable timeout to LLM retry decorator

Description

Modify retry decorator in KeywordsAI and OpenAI LLM integrations to support a configurable timeout parameter, defaulting to 60 seconds

Fixes # #17756

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Modify retry decorator in KeywordsAI and OpenAI LLM integrations to support a configurable timeout parameter, defaulting to 60 seconds
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 8, 2025
@ramarnat ramarnat changed the title feat: Add configurable timeout to LLM retry decorator Bug Fix: Add configurable timeout to LLM retry decorator Feb 8, 2025
@logan-markewich
Copy link
Collaborator

@ramarnat Any chance you can bump the package version in the openai and keywordsai tomls? I'd do it myself but I can't push to your PR

@ramarnat
Copy link
Contributor Author

ramarnat commented Feb 9, 2025

@logan-markewich will do

@logan-markewich
Copy link
Collaborator

@ramarnat plz? 😁

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@ramarnat
Copy link
Contributor Author

ramarnat commented Feb 17, 2025

@logan-markewich done. How do I give you access to update a PR in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants