add namespaced vector stores to storage context #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatianzhang
reviewed
Nov 7, 2023
hatianzhang
reviewed
Nov 7, 2023
hatianzhang
approved these changes
Nov 7, 2023
mikeldking
reviewed
Nov 9, 2023
| ) -> Dict[str, VectorStore]: | ||
| """Load from namespaced persist dir.""" | ||
| vector_stores: Dict[str, VectorStore] = {} | ||
| for fname in os.listdir(persist_dir): |
There was a problem hiding this comment.
@logan-markewich I think this line may have broken using a remote fs like gcsfs?
ryanpeach
pushed a commit
to OnScale/llama_index
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some scenarios where you may want several vector indexes, and those vector indexes could come from any vector db provider.
This PR updates the storage context to add high-level namespaces for vector stores, to help support future development.
I have personally tested storing/loading old and new indexes for backwards compatibility.
Type of Change
How Has This Been Tested?