Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding routers to high level concepts #8810

Merged

Conversation

aaronjimv
Copy link
Contributor

Description

This PR includes the changes requested in [Documentation]: adding Routers to High-Level Concepts #7884

The routers concept was added to High-Level Concepts.

Also fixing a typo in the file (and and → and).

Fixes #7884

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@aaronjimv
Copy link
Contributor Author

Hello, I am open to any feedback or suggestions.

@Disiok
Copy link
Collaborator

Disiok commented Nov 10, 2023

Thanks!

@Disiok Disiok merged commit 9672370 into run-llama:main Nov 10, 2023
@aaronjimv
Copy link
Contributor Author

Happy to help.

@aaronjimv aaronjimv deleted the Adding_Routers_to_High-Level_Concepts branch November 13, 2023 14:24
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
ryanpeach pushed a commit to OnScale/llama_index that referenced this pull request Feb 7, 2024
* fixing typo (and and -> and)

* Adding routers concep

* Adding link to router concep
@ryanpeach ryanpeach mentioned this pull request Feb 7, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: adding Routers to High-Level Concepts
2 participants